[
https://issues.apache.org/jira/browse/HADOOP-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920096#action_12920096
]
dhruba borthakur commented on HADOOP-6996:
------------------------------------------
Code looks good. One minor comment:
{code}
public CompressionCodec getCodecByClassName(String classname) {
if (codecsByClassName == null) {
return null;
}
return codecsByClassName.get(classname);
}
{code}
do we really need to check for codecsByClassName == null? I see that it always
initialized in the constructor.
> Allow CodecFactory to return a codec object given a codec' class name
> ---------------------------------------------------------------------
>
> Key: HADOOP-6996
> URL: https://issues.apache.org/jira/browse/HADOOP-6996
> Project: Hadoop Common
> Issue Type: New Feature
> Components: io
> Affects Versions: 0.22.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.22.0
>
> Attachments: getCodecByClassName.patch, getCodecByClassName1.patch
>
>
> CodecFactory specify the list of codec that are supported by Hadoop. However,
> it returns a codec only by a file's name. I would like to make getCodec
> method to alternatively take a codec's class name.
> This is required by HDFS-1435, where
> 1. it allows an HDFS admin to configure which codec to use to save an image.
> 2. It stores the codec class name in its on-disk image instead of a file's
> suffix.
> When saving and reading an image, I'd like to get an codec from CodecFactory
> by its class name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
