[ https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290976#comment-15290976 ]
Steve Loughran commented on HADOOP-13154: ----------------------------------------- BTW, that commit you found with git blame isn't in branch-2.7; the code came in HADOOP-10400, the original S3A donation. > S3AFileSystem printAmazonServiceException/printAmazonClientException appear > copy & paste of AWS examples > -------------------------------------------------------------------------------------------------------- > > Key: HADOOP-13154 > URL: https://issues.apache.org/jira/browse/HADOOP-13154 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 2.7.2 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Blocker > Attachments: HADOOP-13154-branch-2.7-001.patch > > > The logging code in {{S3AFileSystem.printAmazonServiceException()}} and > {{printAmazonClientException}} appear to be paste + edits of the example code > in the amazon SDK, such as > [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]] > Either we review the license to validate it, and add credits to the code if > compatible, or we rework. HADOOP-13130 would be the place to do that, as it > is changing exception handling anyway. > tagging as blocker as it is license related -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org