[
https://issues.apache.org/jira/browse/HADOOP-13207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355585#comment-15355585
]
Aaron Fabbri commented on HADOOP-13207:
---------------------------------------
Reviewing the 006 patch.
{code}
+### `listStatus(Path path, PathFilter filter): FileStatus[]`
{code}
...
{code}
+Lists all those immediate children of a path whose pathnames are accepted by
+the path filter.
{code}
Should we explicitly mention that the listing does not include the directory
itself, only its children? It sounds a bit redundant I guess. I'll leave it
up to you.
Overall the patch looks good. Really appreciate this work. +1
> Specify FileSystem listStatus and listFiles
> -------------------------------------------
>
> Key: HADOOP-13207
> URL: https://issues.apache.org/jira/browse/HADOOP-13207
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, fs
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13207-branch-2-001.patch,
> HADOOP-13207-branch-2-002.patch, HADOOP-13207-branch-2-003.patch,
> HADOOP-13207-branch-2-004.patch, HADOOP-13207-branch-2-005.patch,
> HADOOP-13207-branch-2-006.patch
>
>
> The many `listStatus`, `listLocatedStatus` and `listFiles` operations have
> not been completely covered in the FS specification. There's lots of implicit
> use of {{listStatus()}} path, but no coverage or tests of the others.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
