[ https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364333#comment-15364333 ]
Daniel Templeton commented on HADOOP-13254: ------------------------------------------- [~rkanter], if an instance is creating threads in the constructor, that would make it a very naughty instance indeed. Without an API that allows for a clean shutdown, creating threads is a risky proposition. I agree with [~yufeigu] that when it comes to adding threads, whoever wants to add threads should change the API to include start and stop methods. Since we can't make any guarantees about what future contributors will do, I also agree that being more defensive isn't a bad idea. The cheapest solution I see is to use locks. > Create framework for configurable disk checkers > ----------------------------------------------- > > Key: HADOOP-13254 > URL: https://issues.apache.org/jira/browse/HADOOP-13254 > Project: Hadoop Common > Issue Type: Bug > Components: util > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, > HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, > HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org