[ https://issues.apache.org/jira/browse/HADOOP-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928658#action_12928658 ]
Hadoop QA commented on HADOOP-6297: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422611/zlibpatch-0.3.patch against trunk revision 1031422. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/69//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/69//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/69//console This message is automatically generated. > Hadoop's support for zlib library lacks support to perform flushes > (Z_SYNC_FLUSH and Z_FULL_FLUSH) > -------------------------------------------------------------------------------------------------- > > Key: HADOOP-6297 > URL: https://issues.apache.org/jira/browse/HADOOP-6297 > Project: Hadoop Common > Issue Type: Improvement > Components: io > Reporter: Kevin J. Price > Assignee: Kevin J. Price > Priority: Minor > Attachments: zlibpatch-0.3.patch, zlibpatch.patch > > > The zlib library supports the ability to perform two types of flushes when > deflating data. It can perform both a Z_SYNC_FLUSH, which forces all input to > be written as output and byte-aligned and resets the Huffman coding, and it > also supports a Z_FULL_FLUSH, which does the same thing but additionally > resets the compression dictionary. The Hadoop wrapper for the zlib library > does not support either of these two methods. > Adding support should be fairly trivial. An additional deflate method that > takes a fourth "flush" parameter, and a modification to the native c code to > accept this fourth parameter and pass it along to the zlib library. I can > submit a patch for this if desired. > It should be noted that the native SUN Java API is likewise missing this > functionality, as has been noted for over a decade here: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4206909 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.