[
https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365355#comment-15365355
]
Aaron T. Myers commented on HADOOP-11540:
-----------------------------------------
Hi [~drankye], overall the latest patch looks pretty good to me. I have a few
small comments, and I'll be +1 once these are addressed:
# Should use the Logger system for this message, instead of going directly to
stdout, likewise for doEncodeByConvertingToDirectBuffers:
{code}
+ System.out.println("WARNING: doDecodeByConvertingToDirectBuffers " +
+ "is used, not efficiently");
{code}
# I think you mean "get/set" here (in two places in the code):
{code}
+ // Set/set and only used by native codes.
{code}
# I think that the constructor for {{ByteBufferEncodingState}} should perhaps
have its argument renamed to "{{encodeLength}}" instead of "{{decodeLength}}"
# Per Colin's earlier suggestion, I think we still have some error checking to
do in {{jni_common.c#setCoder}}, just like you've done in {{getCoder}}.
# A bit of a meta comment: there's so much overlap/repetition between all of
the encoder and decoder classes tha
t I wonder if there isn't some good way of refactoring this code to combine
encoding/decoding functionality in a
single class. Maybe that would make things more complex, but as it stands
there's effectively two copies of a l
ot of the code in this patch. If you'd like to ignore this piece of feedback
for now, that's totally fine, but s
omething to think about.
> Raw Reed-Solomon coder using Intel ISA-L library
> ------------------------------------------------
>
> Key: HADOOP-11540
> URL: https://issues.apache.org/jira/browse/HADOOP-11540
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Zhe Zhang
> Assignee: Kai Zheng
> Labels: hdfs-ec-3.0-must-do
> Attachments: HADOOP-11540-initial.patch, HADOOP-11540-v1.patch,
> HADOOP-11540-v10.patch, HADOOP-11540-v11.patch, HADOOP-11540-v2.patch,
> HADOOP-11540-v4.patch, HADOOP-11540-v5.patch, HADOOP-11540-v6.patch,
> HADOOP-11540-v7.patch, HADOOP-11540-v8.patch, HADOOP-11540-v9.patch,
> HADOOP-11540-with-11996-codes.patch, Native Erasure Coder Performance - Intel
> ISAL-v1.pdf
>
>
> This is to provide RS codec implementation using Intel ISA-L library for
> encoding and decoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
