[ https://issues.apache.org/jira/browse/HADOOP-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HADOOP-13341: -------------------------------------- Description: Big features like YARN-2928 demonstrate that even senior level Hadoop developers forget that daemons need a custom _OPTS env var. We can replace all of the custom vars with generic handling just like we do for the username check. For example, with generic handling in place: || Old Var || New Var || | HADOOP_NAMENODE_OPTS | HDFS_namenode_OPTS | | YARN_RESOURCEMANAGER_OPTS | YARN_resourcemanager_OPTS | | n/a | YARN_timelineserverreader_OPTS | | n/a | HADOOP_distcp_OPTS | | n/a | MAPRED_distcp_OPTS | This makes this: a) consistent across the entire project b) consistent for every subcommand c) eliminates almost all of the custom appending in the case statements was: Big features like YARN-2928 demonstrate that even senior level Hadoop developers forget that daemons need a custom _OPT env var. We can replace all of the custom vars with generic handling just like we do for the username check. For example, today: HADOOP_NAMENODE_OPT would become HADOOP_namenode_OPT But if I wanted custom distcp options, there is no equivalent. But if the command replacement mode was, then HADOOP_distcp_OPT would automatically work. In the case of YARN-2928, HADOOP_timelinereaderserver_OPT would automatically be checked without any extra work on behalf of the contributors. > Deprecate HADOOP_SERVERNAME_OPT; replace with HADOOP_(command)_OPT > ------------------------------------------------------------------ > > Key: HADOOP-13341 > URL: https://issues.apache.org/jira/browse/HADOOP-13341 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts > Affects Versions: 3.0.0-alpha1 > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > > Big features like YARN-2928 demonstrate that even senior level Hadoop > developers forget that daemons need a custom _OPTS env var. We can replace > all of the custom vars with generic handling just like we do for the username > check. > For example, with generic handling in place: > || Old Var || New Var || > | HADOOP_NAMENODE_OPTS | HDFS_namenode_OPTS | > | YARN_RESOURCEMANAGER_OPTS | YARN_resourcemanager_OPTS | > | n/a | YARN_timelineserverreader_OPTS | > | n/a | HADOOP_distcp_OPTS | > | n/a | MAPRED_distcp_OPTS | > This makes this: > a) consistent across the entire project > b) consistent for every subcommand > c) eliminates almost all of the custom appending in the case statements -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org