[ https://issues.apache.org/jira/browse/HADOOP-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396761#comment-15396761 ]
Mingliang Liu commented on HADOOP-13032: ---------------------------------------- I plan to split this big patch to smaller incremental ones along with the TODOs: # Add a new thread-local mechanism for aggregating file system storage stats. This basically includes the new {{ThreadLocalStorageStatistics}} class and its test and changes in {{FileSystemStorageStatistics}} that uses it. This class will also be used in [HADOOP-13031]. After that, the {{FileSystemStorageStatistics}} can live without the deprecated {{FileSystem$Statistics}} implementation. # Make FileSystems, FileContext and MapReduce use the new {{FileSystemStorageStatistics}} interface. # Remove the {{FileSystem$Statistics}} and update all its usages other than step 2. # Separate the distance-specific rack-aware read bytes logic from {{FileSystemStorageStatistics}} to new {{DFSRackAwareStorageStatistics}}. This is tracked by [HADOOP-13031]. # The MapReduce part that explores the FileSystemStorageStatistics should also consider expose rack-aware read bytes {{DFSRackAwareStorageStatistics}}. Ping [~cmccabe], [~jnp], [~ste...@apache.org] and [~mingma]] for discussion. Thanks. > Refactor FileSystem$Statistics to use StorageStatistics > ------------------------------------------------------- > > Key: HADOOP-13032 > URL: https://issues.apache.org/jira/browse/HADOOP-13032 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HADOOP-13032.000.patch, HADOOP-13032.001.patch > > > [HADOOP-13065] added a new interface for retrieving FS and FC Statistics. > This jira is to track the effort of moving the {{Statistics}} class out of > {{FileSystem}}, and make it use that new interface. > We should keep the thread local implementation. Benefits are: > # they could be used in both {{FileContext}} and {{FileSystem}} > # unified stats data structure > # shorter source code > Please note this will be an backwards-incompatible change. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org