[ https://issues.apache.org/jira/browse/HADOOP-13380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yufei Gu updated HADOOP-13380: ------------------------------ Attachment: HADOOP-13380.002.patch > TestBasicDiskValidator should not write data to /tmp > ---------------------------------------------------- > > Key: HADOOP-13380 > URL: https://issues.apache.org/jira/browse/HADOOP-13380 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 2.9.0 > Reporter: Lei (Eddy) Xu > Assignee: Yufei Gu > Priority: Minor > Attachments: HADOOP-13380.001.patch, HADOOP-13380.002.patch > > > In {{TestBasicDiskValidator}}, the following code is confusing > {code} > File localDir = File.createTempFile("test", "tmp"); > try { > if (isDir) { > // reuse the file path generated by File#createTempFile to create a dir > localDir.delete(); > localDir.mkdir(); > } > {code} > Btw, as suggested in https://wiki.apache.org/hadoop/CodeReviewChecklist, unit > test should not write data into {{/tmp}}: > bq. * unit tests do not write any temporary files to /tmp (instead, the tests > should write to the location specified by the test.build.data system property) > Finally, should use {{Files}} in these file creation / deletion, so that any > error can be thrown as {{IOE}}. > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org