[ https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406694#comment-15406694 ]
Arpit Agarwal commented on HADOOP-13466: ---------------------------------------- +1 pending Jenkins. Thanks [~vagarychen] for splitting out this reusable class from the HDFS changes. The unit tests also look good! Separately we can add Javadocs to the AutoCloseableLock methods since a lock class should make its contract explicit. > Using a separate lock class to replace using class object lock > -------------------------------------------------------------- > > Key: HADOOP-13466 > URL: https://issues.apache.org/jira/browse/HADOOP-13466 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Chen Liang > Assignee: Chen Liang > Attachments: HADOOP-13466.001.patch > > > Add a separate lock class object into util, such that we can replace using > class object lock. This would make it easier for us to understand locking > behaviors. e.g., we may easily instrument the new lock class for better > understanding of locking overhead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org