[ 
https://issues.apache.org/jira/browse/HADOOP-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiao Chen updated HADOOP-13437:
-------------------------------
    Attachment: HADOOP-13437.04.patch

Uploading patch 4 as a refined version.

I'm still confused of the {{containsKey}} check though: after an admin replaced 
a kms-acls.xml, why do we only want to update the named keys, but keep the old 
whitelist/defaults? After the replacement (suppose there was no backup), how 
could the admin figure out what exactly the whitelist/defaults are? The config 
file is not loaded, and nowhere else to look at....

[~asuresh], could you please chime in? Is this an expected behavior (so we need 
to keep compatible behavior), or is this a bug (so we can fix it here)? Thanks 
in advance...

> KMS should reload whitelist and default key ACLs when hot-reloading
> -------------------------------------------------------------------
>
>                 Key: HADOOP-13437
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13437
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13437.01.patch, HADOOP-13437.02.patch, 
> HADOOP-13437.03.patch, HADOOP-13437.04.patch
>
>
> When hot-reloading, {{KMSACLs#setKeyACLs}} ignores whitelist and default key 
> entries if they're present in memory.
> We should reload them, hot-reload and cold-start should not have any 
> difference in behavior.
> Credit to [~dilaver] for finding this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to