[ https://issues.apache.org/jira/browse/HADOOP-13533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Albert Chu updated HADOOP-13533: -------------------------------- Description: In hadoop-functions.sh in the hadoop_basic_init function there is this initialization of HADOOP_SSH_OPTS: {noformat} HADOOP_SSH_OPTS=${HADOOP_SSH_OPTS:-"-o BatchMode=yes -o StrictHostKeyChecking=no -o ConnectTimeout=10s"} {noformat} I believe this parameter substitution is a bug. While most of the environment variables set in the function are generally required for functionality (HADOOP_LOG_DIR, HADOOP_LOGFILE, etc.) I don't believe HADOOP_SSH_OPTS is one of them. If the user wishes to set HADOOP_SSH_OPTS to an empty string (i.e. HADOOP_SSH_OPTS="") they should be able to. But instead, this is requiring HADOOP_SSH_OPTS to always be set to something. So I think the {noformat} ":-" {noformat} in the above should be {noformat} "-" {noformat} Github pull request to be sent shortly. was: In hadoop-functions.sh in the hadoop_basic_init function there is this initialization of HADOOP_SSH_OPTS: {noformat} HADOOP_SSH_OPTS=${HADOOP_SSH_OPTS:-"-o BatchMode=yes -o StrictHostKeyChecking=no -o ConnectTimeout=10s"} {noformat} I believe this parameter substitution is a bug. While most of the environment variables set in the function are generally required for functionality (HADOOP_LOG_DIR, HADOOP_LOGFILE, etc.) I don't believe HADOOP_SSH_OPTS is one of them. If the user wishes to set HADOOP_SSH_OPTS to an empty string (i.e. HADOOP_SSH_OPTS="") they should be able to. But instead, this is requiring HADOOP_SSH_OPTS to always be set to something. So I think the ":-" in the above should be "-". Github pull request to be sent shortly. > User cannot set empty HADOOP_SSH_OPTS environment variable option > ----------------------------------------------------------------- > > Key: HADOOP-13533 > URL: https://issues.apache.org/jira/browse/HADOOP-13533 > Project: Hadoop Common > Issue Type: Bug > Components: scripts > Affects Versions: 3.0.0-alpha2 > Reporter: Albert Chu > Priority: Minor > > In hadoop-functions.sh in the hadoop_basic_init function there is this > initialization of HADOOP_SSH_OPTS: > {noformat} > HADOOP_SSH_OPTS=${HADOOP_SSH_OPTS:-"-o BatchMode=yes -o > StrictHostKeyChecking=no -o ConnectTimeout=10s"} > {noformat} > I believe this parameter substitution is a bug. While most of the > environment variables set in the function are generally required for > functionality (HADOOP_LOG_DIR, HADOOP_LOGFILE, etc.) I don't believe > HADOOP_SSH_OPTS is one of them. If the user wishes to set HADOOP_SSH_OPTS to > an empty string (i.e. HADOOP_SSH_OPTS="") they should be able to. But > instead, this is requiring HADOOP_SSH_OPTS to always be set to something. > So I think the > {noformat} > ":-" > {noformat} > in the above should be > {noformat} > "-" > {noformat} > Github pull request to be sent shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org