[ 
https://issues.apache.org/jira/browse/HADOOP-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439414#comment-15439414
 ] 

Anu Engineer commented on HADOOP-7363:
--------------------------------------

Thanks for the new patch. It looks really good. One small issue, my apologies 
for not noticing this in the earlier code reviews.
We seem to use a path ==> "/test/newDir" shouldn't this be relative to the test 
directory rather than absolute path ? Otherwise the patch is good to go.

> TestRawLocalFileSystemContract is needed
> ----------------------------------------
>
>                 Key: HADOOP-7363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7363
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: fs
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Matt Foley
>            Assignee: Andras Bokor
>         Attachments: HADOOP-7363.01.patch, HADOOP-7363.02.patch, 
> HADOOP-7363.03.patch, HADOOP-7363.04.patch, HADOOP-7363.05.patch, 
> HADOOP-7363.06.patch
>
>
> FileSystemContractBaseTest is supposed to be run with each concrete 
> FileSystem implementation to insure adherence to the "contract" for 
> FileSystem behavior.  However, currently only HDFS and S3 do so.  
> RawLocalFileSystem, at least, needs to be added. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to