[ 
https://issues.apache.org/jira/browse/HADOOP-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471344#comment-15471344
 ] 

Chris Nauroth commented on HADOOP-13518:
----------------------------------------

I tried again, but I still saw failures:

{code}
Running org.apache.hadoop.fs.s3.ITestInMemoryS3FileSystemContract
Tests run: 43, Failures: 5, Errors: 1, Skipped: 0, Time elapsed: 0.912 sec <<< 
FAILURE! - in org.apache.hadoop.fs.s3.ITestInMemoryS3FileSystemContract
{code}

Steve, I noticed my output says 43 tests were run, but your output says 31 
tests were run.  The patch adds 12 new tests in the base class, so maybe you 
still need to run {{mvn install}} in hadoop-common before running the test 
suite.

bq. FWIW, as this test is local, could it be converted from an Integration test 
to a simple Test?

That was my first instinct when I worked on HADOOP-13446.  Unfortunately, I 
discovered that even though the test is local, the code still has a dependency 
on the presence of auth-keys.xml because of extending 
{{S3FileSystemContractBaseTest}}.  A similar issue applies to 
{{ITestInMemoryNativeS3FileSystemContract}}.  It would be nice to break that 
dependency, but since we're avoiding changes in "s3:" and "s3n:", I chose to 
take the shorter path of converting them to integration tests.

> backport HADOOP-9258 to branch-2
> --------------------------------
>
>                 Key: HADOOP-13518
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13518
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs, fs/s3, test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-13518-branch-2-001.patch
>
>
> I've just realised that HADOOP-9258 was never backported to branch 2. It went 
> in to branch 1, and into trunk, but not in the bit in the middle.
> It adds
> -more fs contract tests
> -s3 and s3n rename don't let you rename under yourself (and delete)
> I'm going to try to create a patch for this, though it'll be tricky given how 
> things have moved around a lot since then. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to