[ https://issues.apache.org/jira/browse/HADOOP-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478811#comment-15478811 ]
Mingliang Liu commented on HADOOP-13588: ---------------------------------------- Can you add @VisibleForTesting annotation to parseAccecptHeader() method? Otherwise +1 for the patch. I'll leave this open for 2nd opinion as it's incompatible change. > ConfServlet doesn't set response content type according to the Accept header > ----------------------------------------------------------------------------- > > Key: HADOOP-13588 > URL: https://issues.apache.org/jira/browse/HADOOP-13588 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Attachments: HADOOP-13588.001.patch > > > ConfServlet provides a general service to retrieve daemon configurations. > However it doesn't set response content-type according to *Accept* header. > For example, by issuing following command, > {code} > curl --header "Accept:application/json" > http://${resourcemanager_host}:8088/conf > {code} > I am expecting the response would be in JSON format, however it is still in > XML. I can only get JSON if I issue > {code} > curl http://${resourcemanager_host}:8088/conf?format="json" > {code} > This is not the common way how clients set content-type. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org