[
https://issues.apache.org/jira/browse/HADOOP-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491220#comment-15491220
]
Allen Wittenauer commented on HADOOP-13344:
-------------------------------------------
Two problems:
#1:
{code}
if [[ -n "${HADOOP_USE_BUILTIN_SLF4J_BINDING}:-true" ]];
{code}
This will always be true because there will always be a value for -n to
evaluate. You can test this on the command line:
{code}
$ echo "${HADOOP_USE_BUILTIN_SLF4J_BINDING}:-true"
:-true
{code}
-n is probably the wrong thing to use here. I'd recommend reconstructing so
that you compare HADOOP_USE_BUILTIN_SLF4J_BINDING against an explicit true or
false setting.
#2:
There are unit tests for the shell scripts. In this case,
hadoop-common-project/hadoop-common/src/test/scripts/hadoop_add_common_to_classpath.bats
failed because the value generated by hadoop_add_common_to_classpath is now
generating a different value than what was previously expected due to the extra
classpath being present. The test case should be updated to test both settings
of HADOOP_USE_BUILTIN_SLF4J_BINDING.
> Add option to exclude Hadoop's SLF4J binding
> --------------------------------------------
>
> Key: HADOOP-13344
> URL: https://issues.apache.org/jira/browse/HADOOP-13344
> Project: Hadoop Common
> Issue Type: New Feature
> Components: bin, scripts
> Affects Versions: 2.8.0, 2.7.2
> Reporter: Thomas Poepping
> Assignee: Thomas Poepping
> Labels: patch
> Attachments: HADOOP-13344.01.patch, HADOOP-13344.patch
>
>
> If another application that uses the Hadoop classpath brings in its own SLF4J
> binding for logging, and that jar is not the exact same as the one brought in
> by Hadoop, then there will be a conflict between logging jars between the two
> classpaths. This patch introduces an optional setting to remove Hadoop's
> SLF4J binding from the classpath, to get rid of this problem.
> This patch should be applied to 2.8.0, as bin/ and hadoop-config.sh structure
> has been changed in 3.0.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
