[ https://issues.apache.org/jira/browse/HADOOP-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935618#action_12935618 ]
Konstantin Boudnik commented on HADOOP-7049: -------------------------------------------- looking good. I would suggest to replace {{import static org.junit.Assert.*;}} with only needed imports. Looks like you're using only two of them {{assertTrue}} and {{assertFalse}} > TestReconfiguration should be junit v4 > -------------------------------------- > > Key: HADOOP-7049 > URL: https://issues.apache.org/jira/browse/HADOOP-7049 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Affects Versions: 0.23.0 > Reporter: Patrick Kling > Assignee: Patrick Kling > Priority: Trivial > Attachments: HADOOP-7049.2.patch, HADOOP-7049.patch > > > TestReconfiguration should be a junit v4 unit test. I'll also add some > messages to the assertions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.