[
https://issues.apache.org/jira/browse/HADOOP-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965085#action_12965085
]
Hadoop QA commented on HADOOP-6939:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12464925/HADOOP-6939.patch
against trunk revision 1039959.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.fs.TestLocalFSFileContextMainOperations
org.apache.hadoop.fs.TestLocalFSFileContextSymlink
org.apache.hadoop.fs.TestTrash
org.apache.hadoop.io.TestSequenceFile
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/126//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/126//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/126//console
This message is automatically generated.
> Inconsistent lock ordering in AbstractDelegationTokenSecretManager
> ------------------------------------------------------------------
>
> Key: HADOOP-6939
> URL: https://issues.apache.org/jira/browse/HADOOP-6939
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: HADOOP-6939.patch, hadoop-6939.txt, lockorder.png
>
>
> AbstractDelegationTokenSecretManager.startThreads() is synchronized, which
> calls updateCurrentKey(), which calls logUpdateMasterKey.
> logUpdateMasterKey's implementation for HDFS's manager calls
> namesystem.logUpdateMasterKey() which is synchronized. Thus the lock order is
> ADTSM -> FSN. In FSN.saveNamespace, though, it calls
> DTSM.saveSecretManagerState(), so the lock order is FSN -> ADTSM.
> I don't think this deadlock occurs in practice since saveNamespace won't
> occur until after the ADTSM has started its threads, but should be fixed
> anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
