[ https://issues.apache.org/jira/browse/HADOOP-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingliang Liu updated HADOOP-13658: ----------------------------------- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2 2.8.0 Status: Resolved (was: Patch Available) Thanks [~vagarychen] for your contribution. I have committed this patch to {{trunk}}, {{branch-2}} and {{branch-2.8}}. > Replace config key literal strings with config key names I: hadoop common > ------------------------------------------------------------------------- > > Key: HADOOP-13658 > URL: https://issues.apache.org/jira/browse/HADOOP-13658 > Project: Hadoop Common > Issue Type: Improvement > Components: conf > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Minor > Fix For: 2.8.0, 3.0.0-alpha2 > > Attachments: HADOOP-13658.001.patch, HADOOP-13658.002.patch, > HADOOP-13658.003.patch > > > In Hadoop Common, there are several places where the config keys are used by > the literal strings instead of their names as in configuration key classes. > The default values have the same issue. For example > {code:title=in o.a.h.i.f.t.Compression.java} > conf.setInt("io.compression.codec.lzo.buffersize", 64 * 1024); > {code} > should be > {code} > conf.setInt( > CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY, > CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_DEFAULT); > {code} > instead -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org