[ 
https://issues.apache.org/jira/browse/HADOOP-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547731#comment-15547731
 ] 

Chris Nauroth commented on HADOOP-13614:
----------------------------------------

[~ste...@apache.org], thank you for the nice work here.  It looks good to me.  
I have no other specific feedback.  I would like to take one more review pass 
over it tomorrow morning (PDT) with a clearer head, but I think it's highly 
likely that I will approve after getting a clean pre-commit run.  (As mentioned 
earlier, I think the GitHub pull request needs to be updated to match the 
revision 005 file to trigger pre-commit.)

> Purge some superfluous/obsolete S3 FS tests that are slowing test runs down
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-13614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13614
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-13614-branch-2-001.patch, 
> HADOOP-13614-branch-2-002.patch, HADOOP-13614-branch-2-002.patch, 
> HADOOP-13614-branch-2-004.patch, HADOOP-13614-branch-2-005.patch, testrun.txt
>
>
> Some of the slow test cases contain tests that are now obsoleted by newer 
> ones. For example, {{ITestS3ADeleteManyFiles}} has the test case 
> {{testOpenCreate()}} which writes then reads files up 25 MB.
> Have a look at which of the s3a tests are taking time, review them to see if 
> newer tests have superceded the slow ones; and cut them where appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to