[
https://issues.apache.org/jira/browse/HADOOP-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Kanter updated HADOOP-10075:
-----------------------------------
Attachment: HADOOP-10075.008.patch
Thanks for the feedback [~templedf].
The 008 patch:
- Adds javadoc explaining the {{\@deprecated}}
- Adds a log message to that servlet mapping thing
- Makes cast styling of {{(ServerConnector)}} consistent
- Added spaces around the {{*}} operator
- Updated log messages
- Clarified the comment about Hadoop 3
- Added javadoc in {{TimelineReaderServer#setupOptions}}
- Rebased on latest trunk
And my responses to your remaining feedback:
- I couldn't put in a diamond operator there; it didn't like that.
- The only removed class is {{SslSelectChannelConnectorSecure}}, which was
marked private, so I think we're okay removing it.
- I'm not sure I understand your comment about the space and the semicolon. I
know I updated the {{\@Produces}} a lot, but as far as I can tell, they're all
identical. Can you give me some file names and lines where they differ?
- On the test timeout increase, I had to increase it because the server now
takes longer to shutdown. I did some checking, and with Jetty 9, it takes
~3000ms, but with Jetty 6, it takes only ~100ms. Due to this, I had to
increase the timeout. I'm not sure there's much we can do about this; it's
mostly Jetty code and I didn't change much in the stop method.
- I looks like the way to get the utf-8 charset as a constant String is via
{{StandardCharsets.UTF_8.name()}}. Any suggestions on an easy way to do that?
There's over 600 instances of this in the patch.
- I agree that it's generally good to put messages into assert statements, but
I don't think that's necessary when it's obvious what it's checking and what is
wrong with it. We're clearly checking the response type here, and when it's
incorrect, you get an obvious message like this:
{noformat}
org.junit.ComparisonFailure:
Expected :application/json; charset=foo
Actual :application/json; charset=utf-8
{noformat}
Adding a message like "Expected response type X but got response type Y" won't
be any more helpful than this.
> Update jetty dependency to version 9
> ------------------------------------
>
> Key: HADOOP-10075
> URL: https://issues.apache.org/jira/browse/HADOOP-10075
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.2.0, 2.6.0
> Reporter: Robert Rati
> Assignee: Robert Kanter
> Attachments: HADOOP-10075-002-wip.patch, HADOOP-10075.003.patch,
> HADOOP-10075.004.patch, HADOOP-10075.005.patch, HADOOP-10075.006.patch,
> HADOOP-10075.007.patch, HADOOP-10075.008.patch, HADOOP-10075.patch
>
>
> Jetty6 is no longer maintained. Update the dependency to jetty9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
