[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971040#action_12971040 ]
Tom White commented on HADOOP-6298: ----------------------------------- How about adding {{getBytesNonPadded()}} which creates a copy in a non-padded byte array? By naming it like this, this name would appear next to {{getBytes()}} in IDE autocompletion lists, which hopefully would alert users to the difference between the two methods. > BytesWritable#getBytes is a bad name that leads to programming mistakes > ----------------------------------------------------------------------- > > Key: HADOOP-6298 > URL: https://issues.apache.org/jira/browse/HADOOP-6298 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 0.20.1 > Reporter: Nathan Marz > > Pretty much everyone at Rapleaf who has worked with Hadoop has misused > BytesWritable#getBytes at some point, not expecting the byte array to be > padded. I think we can completely alleviate these programming mistakes by > deprecating and renaming this method (again) to be more descriptive. I > propose "getPaddedBytes()" or "getPaddedValue()". It would also be helpful to > have a helper method "getNonPaddedValue()" that makes a copy into a > non-padded byte array. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.