[ 
https://issues.apache.org/jira/browse/HADOOP-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583444#comment-15583444
 ] 

Mingliang Liu commented on HADOOP-13032:
----------------------------------------

[~ste...@apache.org], yes it changes the public API, largely 
{{FileSystem$Statistics}} -> {{StorageStatistics}}

The major concern indeed is to update the client-side code accordingly. For MR 
I changed their usage in this large patch (can be split into sub-task JIRAS); 
but for other projects we have to provide separate patches. We can use stat 
type enums as well as iterators in {{StorageStatistics}} so the new client code 
will be simpler and consistent (hopefully).

Thanks,

> Refactor FileSystem$Statistics to use StorageStatistics
> -------------------------------------------------------
>
>                 Key: HADOOP-13032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13032
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-13032.000.patch, HADOOP-13032.001.patch, 
> HADOOP-13032.002.patch, HADOOP-13032.003.patch
>
>
> [HADOOP-13065] added a new interface for retrieving FS and FC Statistics. 
> This jira is to track the effort of moving the {{Statistics}} class out of 
> {{FileSystem}}, and make it use that new interface.
> We should keep the thread local implementation. Benefits are:
> # they could be used in both {{FileContext}} and {{FileSystem}}
> # unified stats data structure
> # shorter source code
> Please note this will be an backwards-incompatible change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to