[ https://issues.apache.org/jira/browse/HADOOP-13720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603718#comment-15603718 ]
Xiao Chen commented on HADOOP-13720: ------------------------------------ Thanks [~yzhangal] for the patch. Looking at the class, I think we should also improve message for a similar case. {code} if (id.getMaxDate() < now) { throw new InvalidToken(renewer + " tried to renew an expired token"); } {code} What do you think? > Add more info to "token ... is expired" message > ----------------------------------------------- > > Key: HADOOP-13720 > URL: https://issues.apache.org/jira/browse/HADOOP-13720 > Project: Hadoop Common > Issue Type: Improvement > Components: common, security > Reporter: Yongjun Zhang > Assignee: Yongjun Zhang > Priority: Trivial > Labels: supportability > Attachments: HADOOP-13720.001.patch > > > Currently AbstractDelegationTokenSecretManager$checkToken does > {code} > protected DelegationTokenInformation checkToken(TokenIdent identifier) > throws InvalidToken { > assert Thread.holdsLock(this); > DelegationTokenInformation info = getTokenInfo(identifier); > if (info == null) { > throw new InvalidToken("token (" + identifier.toString() > + ") can't be found in cache"); > } > if (info.getRenewDate() < Time.now()) { > throw new InvalidToken("token (" + identifier.toString() + ") is > expired"); > } > return info; > } > {code} > When a token is expried, we throw the above exception without printing out > the {{info.getRenewDate()}} in the message. If we print it out, we could know > for how long the token has not been renewed. This will help us investigate > certain issues. > Create this jira as a request to add that part. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org