Yuhao Bi created HADOOP-13765:
---------------------------------

             Summary: Return HomeDirectory if possible in SFTPFileSystem
                 Key: HADOOP-13765
                 URL: https://issues.apache.org/jira/browse/HADOOP-13765
             Project: Hadoop Common
          Issue Type: Bug
          Components: fs
            Reporter: Yuhao Bi


In SFTPFileSystem#getHomeDirectory(), we disconnect the ChannelSftp in finally 
block.
If we get the homeDir Path successfully but got an IOE in the finally block we 
will return the null result.
Maybe we can simply ignore this IOE and just return the result we have 
got.Related codes are shown below.
{code:title=SFTPFileSystem.java|borderStyle=solid}
  public Path getHomeDirectory() {
    ChannelSftp channel = null;
    try {
      channel = connect();
      Path homeDir = new Path(channel.pwd());
      return homeDir;
    } catch (Exception ioe) {
      return null;
    } finally {
      try {
        disconnect(channel);
      } catch (IOException ioe) {
        //May be we can just ignore this IOE
        return null;
      }
    }
  }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to