[
https://issues.apache.org/jira/browse/HADOOP-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615373#comment-15615373
]
Shane Kumpf commented on HADOOP-13603:
--------------------------------------
No tests are included as this is a change to the checkstyle rules. I did create
a dummy class in the runtime docker package and this rule worked to suppress
the package line length error.
I'm unsure of where the asflicense issues are coming from? Those files are not
in my patch and appear unrelated?
I believe this is ready for review.
> Remove package line length checkstyle rule
> ------------------------------------------
>
> Key: HADOOP-13603
> URL: https://issues.apache.org/jira/browse/HADOOP-13603
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: HADOOP-13603.001.patch
>
>
> The packages related to the DockerLinuxContainerRuntime all exceed the 80
> char line length limit enforced by checkstyle. This causes every build to
> fail with a -1. I would like to exclude this rule from causing a failure.
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerCommandExecutor.java:17:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;:
> Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerContainerStatusHandler.java:17:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;:
> Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/package-info.java:23:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;:
> Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/MockPrivilegedOperationCaptor.java:17:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged;:
> Line is longer than 80 characters (found 84).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerRuntimeTestingUtils.java:17:package
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime;:
> Line is longer than 80 characters (found 81).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/MockDockerContainerStatusHandler.java:17:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;:
> Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerCommandExecutor.java:17:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;:
> Line is longer than 80 characters (found 88).
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerContainerStatusHandler.java:17:package
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;:
> Line is longer than 80 characters (found 88).
> {code}
> Alternatively, we could look to restructure the packages here, but I question
> what value this check really provides.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
