[ 
https://issues.apache.org/jira/browse/HADOOP-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974441#action_12974441
 ] 

Erik Steffl commented on HADOOP-6864:
-------------------------------------

HADOOP-6864-0.22-3.patch fixes test-patch issues:

  - member functions in NetgroupCache are static now (they only access static 
members) - per findbug findings

  - Groups.getUserToGroupsMappingService is marked synchronized - per findbug 
findings

Patch-test output:


     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 4 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.


> Provide a JNI-based implementation of ShellBasedUnixGroupsNetgroupMapping 
> (implementation of GroupMappingServiceProvider)
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6864
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6864
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6864-0.20.1xx-1.patch, 
> HADOOP-6864-0.20.1xx.patch, HADOOP-6864-0.22-1.patch, 
> HADOOP-6864-0.22-2.patch, HADOOP-6864-0.22-3.patch, HADOOP-6864-0.22.patch
>
>
> The netgroups implementation of GroupMappingServiceProvider (see 
> ShellBasedUnixGroupsNetgroupMapping.java) does a fork of a unix command to 
> get the netgroups of a user. Since the group resolution happens in the 
> servers, this might be costly. This jira aims at providing a JNI-based 
> implementation for GroupMappingServiceProvider.
> Note that this is similar to what 
> https://issues.apache.org/jira/browse/HADOOP-6818 does for implementation of 
> GroupMappingServiceProvider that  supports only unix groups.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to