[
https://issues.apache.org/jira/browse/HADOOP-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663747#comment-15663747
]
ASF GitHub Bot commented on HADOOP-13817:
-----------------------------------------
GitHub user QwertyManiac opened a pull request:
https://github.com/apache/hadoop/pull/161
HADOOP-13817. Add a finite shell command timeout to
ShellBasedUnixGroupsMapping.
- Tests required log capture so the LOG variable was elevated in
visibility, which required changes in a few test methods unrelated to just this
change.
- Timeout is applied to both, the regular groups and the partial group
listing check commands.
- Default is left to 0 to not break current behaviour (i.e. to wait forever
until groups are resolvable).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QwertyManiac/hadoop HADOOP-13817
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit 6707438a05d46ac57b230d4e9ade59a1a935c9c3
Author: Harsh J <ha...@cloudera.com>
Date: 2016-11-14T10:29:58Z
HADOOP-13817. Add a finite shell command timeout to
ShellBasedUnixGroupsMapping.
----
> Add a finite shell command timeout to ShellBasedUnixGroupsMapping
> -----------------------------------------------------------------
>
> Key: HADOOP-13817
> URL: https://issues.apache.org/jira/browse/HADOOP-13817
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 2.6.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
>
> The ShellBasedUnixGroupsMapping run various {{id}} commands via the
> ShellCommandExecutor modules without a timeout set (its set to 0, which
> implies infinite).
> If this command hangs for a long time on the OS end due to an unresponsive
> groups backend or other reasons, it also blocks the handlers that use it on
> the NameNode (or other services that use this class). That inadvertently
> causes odd timeout troubles on the client end where its forced to retry (only
> to likely run into such hangs again with every attempt until at least one
> command returns).
> It would be helpful to have a finite command timeout after which we may give
> up on the command and return the result equivalent of no groups found.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
