[
https://issues.apache.org/jira/browse/HADOOP-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665346#comment-15665346
]
Lei (Eddy) Xu commented on HADOOP-13449:
----------------------------------------
Hi, [~liuml07]
The patch LGTM overall. +1. I am OK to commit the last patch in the feature
branch.
Some nits that are not necessary to be addressed in this patch:
* {{void deleteTable()}} should be an interface method for {{MetadataStore}},
and maybe rename it to {{destroy()}} / {{tearDown()}}? Each MS should have this
function and not all of them are implemented "table" concept.
* Can we move {{createTable()}} from {{initialization()}} ? or add a flag like
{{CREATE_IF_NOT_EXISTS}} in configuration? Because for the {{s3guard destroy -m
URI}} command, it needs to initialize the DynamoDBMetadataStore instance first
and then call {{destroy()}} / {{deleteTable()}}.
> S3Guard: Implement DynamoDBMetadataStore.
> -----------------------------------------
>
> Key: HADOOP-13449
> URL: https://issues.apache.org/jira/browse/HADOOP-13449
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Chris Nauroth
> Assignee: Mingliang Liu
> Attachments: HADOOP-13449-HADOOP-13345.000.patch,
> HADOOP-13449-HADOOP-13345.001.patch, HADOOP-13449-HADOOP-13345.002.patch,
> HADOOP-13449-HADOOP-13345.003.patch, HADOOP-13449-HADOOP-13345.004.patch
>
>
> Provide an implementation of the metadata store backed by DynamoDB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
