[ https://issues.apache.org/jira/browse/HADOOP-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701685#comment-15701685 ]
Steve Loughran commented on HADOOP-13818: ----------------------------------------- Ideally I'd like that getFileStatus call skipped unless either of the == null conditions meant it was needed. I know that's probably excessive, but with all the object store work I've been doing, I've come to view those calls as potentially very expensive. We should do our best to minimise their use, even in the localFS, in case someone is using that code as the basis for working with a distributed FS like Gluster or Lustre > TestLocalFileSystem#testSetTimes fails > -------------------------------------- > > Key: HADOOP-13818 > URL: https://issues.apache.org/jira/browse/HADOOP-13818 > Project: Hadoop Common > Issue Type: Bug > Components: test > Environment: Mac OS Sierra, OpenJDK 8u122-ea > Reporter: Akira Ajisaka > Assignee: Yiqun Lin > Priority: Minor > Attachments: HADOOP-13818.001.patch, HADOOP-13818.002.patch > > > {noformat} > Running org.apache.hadoop.fs.TestLocalFileSystem > Tests run: 20, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 4.887 sec > <<< FAILURE! - in org.apache.hadoop.fs.TestLocalFileSystem > testSetTimes(org.apache.hadoop.fs.TestLocalFileSystem) Time elapsed: 0.084 > sec <<< FAILURE! > java.lang.AssertionError: expected:<23456000> but was:<1479176144000> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.junit.Assert.assertEquals(Assert.java:542) > at > org.apache.hadoop.fs.TestLocalFileSystem.checkTimesStatus(TestLocalFileSystem.java:391) > at > org.apache.hadoop.fs.TestLocalFileSystem.testSetTimes(TestLocalFileSystem.java:414) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org