[ https://issues.apache.org/jira/browse/HADOOP-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746274#comment-15746274 ]
Ravi Prakash commented on HADOOP-13898: --------------------------------------- Looks good to me. +1. Committing to branch-2 shortly. > should set HADOOP_JOB_HISTORYSERVER_HEAPSIZE only if it's empty on branch2 > -------------------------------------------------------------------------- > > Key: HADOOP-13898 > URL: https://issues.apache.org/jira/browse/HADOOP-13898 > Project: Hadoop Common > Issue Type: Bug > Components: scripts > Affects Versions: 2.9.0 > Reporter: Fei Hui > Assignee: Fei Hui > Attachments: HADOOP-13898-branch-2.001.patch, > HADOOP-13898-branch-2.002.patch > > > In mapred-env, set HADOOP_JOB_HISTORYSERVER_HEAPSIZE 1000 by default, That is > incorrect. > We should set it 1000 by default only if it's empty. > Because if you run 'HADOOP_JOB_HISTORYSERVER_HEAPSIZE =512 > $HADOOP_HOME/sbin/mr-jobhistory-daemon.sh start historyserver', > HADOOP_JOB_HISTORYSERVER_HEAPSIZE will be set 1000, rather than 512. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org