[ 
https://issues.apache.org/jira/browse/HADOOP-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981599#action_12981599
 ] 

Allen Wittenauer commented on HADOOP-7089:
------------------------------------------

Eli asked me to double check it.  This is a change in behavior, but I think it 
will be safe as well as portable so long as the bash built-ins are used.  It 
might be worthwhile adding that in the comments that we're depending upon the 
built-ins in case someone does something like port Hadoop to busybox.  [Think 
appliance.]

So, +1 if some changes are made to the comments.

> Fix link resolution logic in hadoop-config.sh
> ---------------------------------------------
>
>                 Key: HADOOP-7089
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7089
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hadoop-7089-1.patch, hadoop-7089-1.patch, 
> hadoop-7089-2.patch
>
>
> The link resolution logic in bin/hadoop-config.sh fails when when executed 
> via a symlink, from the root directory.  We can replace this logic with cd -P 
> and pwd -P, which should be portable across Linux, Solaris, BSD, and OSX. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply via email to