[ https://issues.apache.org/jira/browse/HADOOP-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815166#comment-15815166 ]
Steve Loughran commented on HADOOP-13650: ----------------------------------------- With the filesystem driven customisation, we should be taking the table name as a cue for all information related to a bucket; that is used to propagate policies down, including DDB options. regarding the code * I like how you do the tests, execing the CLI entry point. * {{S3GuardTool}} could just import Constants.* * {{static private boolean exist(DynamoDB dynamoDB, String tableName)}} should be {{private static}} and can use Assert inline, rather than preconditions * I think we should also have an fsck command which compares actual and declared, with different action options: fix up ddb, or fail with an exit code. I don't know if that needs to be in this patch though, or a followon > S3Guard: Provide command line tools to manipulate metadata store. > ----------------------------------------------------------------- > > Key: HADOOP-13650 > URL: https://issues.apache.org/jira/browse/HADOOP-13650 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: HADOOP-13345 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Attachments: HADOOP-13650-HADOOP-13345.000.patch, > HADOOP-13650-HADOOP-13345.001.patch, HADOOP-13650-HADOOP-13345.002.patch, > HADOOP-13650-HADOOP-13345.003.patch, HADOOP-13650-HADOOP-13345.004.patch, > HADOOP-13650-HADOOP-13345.005.patch, HADOOP-13650-HADOOP-13345.006.patch > > > Similar systems like EMRFS has the CLI tools to manipulate the metadata > store, i.e., create or delete metadata store, or {{import}}, {{sync}} the > file metadata between metadata store and S3. > http://docs.aws.amazon.com//ElasticMapReduce/latest/ReleaseGuide/emrfs-cli-reference.html > S3Guard should offer similar functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org