[ 
https://issues.apache.org/jira/browse/HADOOP-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871884#comment-15871884
 ] 

Steve Loughran commented on HADOOP-14090:
-----------------------------------------

Having separate region/endpoint just confuses me. The docs will need a 
paragraph on it. Key thing: the endpoint specifies the s3 endpoint for 
authentication. If I specify DDB region, what does that mean for the s3a 
bucket? What if they are different...does that just run DDB somewhere else?

other than that

* Unix convention is to use -- for long commands, so if an app supports single 
char options, you can combine them {{tar \-xvf == tar \-x \-v \-f}}. So use 
"\-\-" as the prefix here.
* please use shared string constants for "region" and "endpoint" in code & 
tests.
* -1 to TODOs in code. Better to add a new JIRA item rather than leave comments 
in the source with will inevitably get forgotten about. JIRA should be where 
the entire TODO list should be documented.

 

> Allow users to specify region for DynamoDB table instead of endpoint
> --------------------------------------------------------------------
>
>                 Key: HADOOP-14090
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14090
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>         Attachments: HADOOP-14090-HADOOP-13345.001.patch
>
>
> Assuming the AWS SDK allows this, I think this would be a better way to 
> configure it for any usage on AWS itself (with endpoint still being an option 
> for AWS-compatible non-AWS use cases). Unless users actually care about a 
> specific endpoint, this is easier. Perhaps less important, HADOOP-14023 shows 
> that inferring the region from the endpoint (which granted, isn't that 
> necessary) doesn't work very well at all.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to