[
https://issues.apache.org/jira/browse/HADOOP-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888738#comment-15888738
]
Hadoop QA commented on HADOOP-14094:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s{color}
| {color:red} HADOOP-14094 does not apply to HADOOP-13345. Rebase required?
Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-14094 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12855202/HADOOP-14094-HADOOP-13345.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11734/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Rethink S3GuardTool options
> ---------------------------
>
> Key: HADOOP-14094
> URL: https://issues.apache.org/jira/browse/HADOOP-14094
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments: HADOOP-14094-HADOOP-13345.001.patch,
> HADOOP-14094-HADOOP-13345.002.patch, HADOOP-14094-HADOOP-13345.003.patch
>
>
> I think we need to rework the S3GuardTool options. A couple of problems I've
> observed in the patches I've done on top of that and seeing other developers
> trying it out:
> * We should probably wrap the current commands in an S3Guard-specific
> command, since 'init', 'destroy', etc. don't touch the buckets at all.
> * Convert to whole-word options, as the single-letter options are already
> getting overloaded. Some patches I've submitted have added functionality
> where the obvious flag is already in use (e.g. -r for region, and read
> throughput, -m for minutes, and metadatastore uri). I may do this early as
> part of HADOOP-14090.
> * We have some options that must be in the config in some cases, and can be
> in the command in other cases. But I've seen someone try to specify the table
> name in the config and leave out the -m option, with no luck. Also, since
> commands hard-code table auto-creation, you might have configured table
> auto-creation, try to import to a non-existent table, and it tells you table
> auto-creation is off.
> We need a more consistent policy for how things should get configured that
> addresses these problems and future-proofs the command a bit more.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
