[
https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989004#comment-12989004
]
Suresh Srinivas commented on HADOOP-6432:
-----------------------------------------
# AbstractFileSystem.java - remove unused import IdentityHashMap
# AbstractFileSystem#getStatistics() - can you make only the inner part that
accesses HashMap synchronized, excluding validation of URI.
# minor: remove empty line changes before AbstractFileSystem#getStatistics()
method.
# STATISTICS_TABLE declaration goes beyond 80 columns
# FileContext#rename() can you change the link in javadoc from Rename#OVERWRITE
to Options.Rename#OVERWRITE to fix a javadoc warning
# FileContext.java - the newly added methods need not be synchronized as it
synchronization is handled by AbstractFileSystem.
# FileContext#getAllStatistics() in javadoc unnecessarily indicates
URISyntaxException is thrown.
# FileContext#clearStatistics() - javadoc should indicate this method clears
statistics for all the file systems.
# FileContext#getStatistics() - for @param uri, have a fullstop after "the uri
to lookup the statistics".
# FileContext#printStatistics() - why does this method throw IOException?
Remove it both from javadoc and declaration.
# Complete the @param argument for new copy constructor in Statistics.
# FCStatisticsBaseTest - "Base class to test File Context Statistics." instead
of File Context add link to FileContext.
# FCStatisticsBaseTest - why do you need exact URI from
getSchemeAuthorityUri()? The API handles any URI by picking scheme and
authority right?
# TestLocalFsFCStatistics - please add comment on why you are doing blockSize +
12? Also please change the class javadoc to indicate that this is testing stats
for LocalFs.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432-trunk.5.patch, HADOOP-6432.1.patch,
> HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
