[ 
https://issues.apache.org/jira/browse/HADOOP-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958477#comment-15958477
 ] 

Kai Zheng commented on HADOOP-13665:
------------------------------------

Thanks [~lewuathe] for the update and [~jojochuang] for the comments! It looks 
close now. I like the idea of {{createRawEncoderWithFallback}} a lot.

bq. would it make sense to update IO_ERASURECODE_CODEC_RS_RAWCODERS_DEFAULT to 
be org....NativeRSRawErasureCoderFactory,org.....RSRawErasureCoderFactory? 

Yes, we should configure like this, instead of the way as below:
{code}
+  public static final String IO_ERASURECODE_CODEC_RS_RAWCODERS_DEFAULT =
+      "rs,rs-legacy";
{code}
[~lewuathe], for your understanding, *rs* and *rs-legacy* are different codecs 
so we'd better not mix them.


> Erasure Coding codec should support fallback coder
> --------------------------------------------------
>
>                 Key: HADOOP-13665
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13665
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Wei-Chiu Chuang
>            Assignee: Kai Sasaki
>            Priority: Blocker
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HADOOP-13665.01.patch, HADOOP-13665.02.patch, 
> HADOOP-13665.03.patch, HADOOP-13665.04.patch, HADOOP-13665.05.patch, 
> HADOOP-13665.06.patch, HADOOP-13665.07.patch, HADOOP-13665.08.patch, 
> HADOOP-13665.09.patch
>
>
> The current EC codec supports a single coder only (by default pure Java 
> implementation). If the native coder is specified but is unavailable, it 
> should fallback to pure Java implementation.
> One possible solution is to follow the convention of existing Hadoop native 
> codec, such as transport encryption (see {{CryptoCodec.java}}). It supports 
> fallback by specifying two or multiple coders as the value of property, and 
> loads coders in order.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to