[
https://issues.apache.org/jira/browse/HADOOP-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994489#comment-12994489
]
Tom White commented on HADOOP-7140:
-----------------------------------
This looks fine, but I wonder if it would be simpler to act on the
InterruptedException in Reader (rather than just log it as the code currently
does) so the thread exits when the pool is shutdown?
Minor nit: add messages to the test assertions so that the case of zero running
threads can be more easily distinguished for the before and after case.
> IPC Reader threads do not stop when server stops
> ------------------------------------------------
>
> Key: HADOOP-7140
> URL: https://issues.apache.org/jira/browse/HADOOP-7140
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hadoop-7140.txt
>
>
> After HADOOP-6713, the new IPC "Reader" threads are not properly stopped when
> the server shuts down. One repercussion of this is that conditions that are
> supposed to shut down a daemon no longer work (eg the TT doesn't shut itself
> down if it detects an incompatible build version)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
