[ 
https://issues.apache.org/jira/browse/HADOOP-14300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968778#comment-15968778
 ] 

Damien Claveau commented on HADOOP-14300:
-----------------------------------------

Hi Wei-Chiu, thank you for the precommit check.
I don't think the failed junit tests on hadoop.security.TestKDiag can be 
related to the patch.

> GraphiteSink reports metrics containing undesirable whitespaces
> ---------------------------------------------------------------
>
>                 Key: HADOOP-14300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14300
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3
>            Reporter: Damien Claveau
>            Assignee: Damien Claveau
>            Priority: Trivial
>         Attachments: HADOOP-14300, HADOOP-14300.001.patch
>
>
> According to the Graphite documentation, the data sent must be in the 
> following format: <metric path> <metric value> <metric timestamp>
> But some tag values that are flattened in the metricpath string sometimes 
> include whitespaces and violate the carbon/graphite format.
> For example, the dirpath enumeration from the datanode : 
> FSDatasetState.org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.Context=FSDatasetState.StorageInfo=FSDataset{dirpath='[/data/1/hdfs/data/current,
>  /data/2/hdfs/data/current]'}.Hostname=worker1.Capacity 78436466688 1491986609
> Currently, none of the aggregators available in the Graphite ecosystem can 
> handle these malformed metrics. These whitespaces should be replaced by 
> underscores.
> I will be happy to attach a small patch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to