[ https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974406#comment-15974406 ]
Tsuyoshi Ozawa commented on HADOOP-14284: ----------------------------------------- {quote} Does this mean we'd have guava in hadoop-client-modules and in hadoop-shaded-thirdparty? What you thinking Tsuyoshi Ozawa? Thanks. {quote} Yes, it does. I choosed the way as a workaround because I think hadoop-client-modules shouldn't expose unshaded Guava to end-users of hadoop. Ideally, I would like to enclose shade inside hadoop-shaded-thirdparty completely to avoid its complexity. I think using Curator itself is a good choice for stable ZKRMStateStore. There are lots things to use ZK correctly as you know, including connection handling, error handling, etc. Curator does these works instead of us. {quote} > Could we get Curator to add a new set of APIs that use Curator-shaded Guava > objects in their API instead? This would let us fully shade our Guava; the > partial shading is unsatisfying. Couldn't we do this shading ourselves? Or worst case, shade our curator use as well? {quote} I think we can. For now, I created branch on my github as a trial. https://github.com/oza/curator/tree/apache-curator-2.12.0-hadoop Its diff from original version is small. https://github.com/oza/curator/commit/7bacc5f79cebaec870f30a85f908fadf3edc95ca The problem is where to manage the code of forked version and where to push jar file. Under hadoop project? > Shade Guava everywhere > ---------------------- > > Key: HADOOP-14284 > URL: https://issues.apache.org/jira/browse/HADOOP-14284 > Project: Hadoop Common > Issue Type: Bug > Components: build > Affects Versions: 3.0.0-alpha3 > Reporter: Andrew Wang > Assignee: Tsuyoshi Ozawa > Priority: Blocker > Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, > HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch > > > HADOOP-10101 upgraded the guava version for 3.x to 21. > Guava is broadly used by Java projects that consume our artifacts. > Unfortunately, these projects also consume our private artifacts like > {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced > by HADOOP-11804, currently only available in 3.0.0-alpha2. > We should shade Guava everywhere to proactively avoid breaking downstreams. > This isn't a requirement for all dependency upgrades, but it's necessary for > known-bad dependencies like Guava. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org