[ https://issues.apache.org/jira/browse/HADOOP-14333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977832#comment-15977832 ]
Andrew Wang commented on HADOOP-14333: -------------------------------------- +1 LGTM, can remove the unused SocketTimeoutException on commit. I'll file Hive and Hadoop JIRAs for tracking adding and using new public APIs. > New exception thrown by (private) DFSClient API isHDFSEncryptionEnabled broke > hacky hive code > ---------------------------------------------------------------------------------------------- > > Key: HADOOP-14333 > URL: https://issues.apache.org/jira/browse/HADOOP-14333 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.8.1, 3.0.0-alpha3 > Reporter: Yongjun Zhang > Assignee: Yongjun Zhang > Attachments: HADOOP-14333.001.patch, HADOOP-14333.002.patch > > > Though Hive should be fixed not to access DFSClient which is private to > HADOOP, removing the throws added by HADOOP-14104 is a quicker solution to > unblock hive. > Hive code > {code} > private boolean isEncryptionEnabled(DFSClient client, Configuration conf) { > try { > DFSClient.class.getMethod("isHDFSEncryptionEnabled"); > } catch (NoSuchMethodException e) { > // the method is available since Hadoop-2.7.1 > // if we run with an older Hadoop, check this ourselves > return !conf.getTrimmed(DFSConfigKeys.DFS_ENCRYPTION_KEY_PROVIDER_URI, > "").isEmpty(); > } > return client.isHDFSEncryptionEnabled(); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org