[
https://issues.apache.org/jira/browse/HADOOP-13200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978968#comment-15978968
]
Wei-Chiu Chuang edited comment on HADOOP-13200 at 4/21/17 4:01 PM:
-------------------------------------------------------------------
I saw a few nits in the 06 patch:
* Could you switch to slf4j? That way you can avoid {{LOG.isDebugEnabled()}}
and can use curl based parameterization.
* Would it be possible to add a test for the case where two coders register the
same name?
* The following code
{code}
" cannot be registered because its coder name " + coderFactory
{code}
shouldn't it be coderFactory.getCoderName()?
* Still in CodecRegistry constructor. I think you want to continue instead of
break if a coder has conflict. Otherwise you would throw an exception instead
of just log an error message.
was (Author: jojochuang):
I saw a few nits in the 06 patch:
* Could you switch to slf4j? That way you can avoid {{LOG.isDebugEnabled()}}
and can use curl based parameterization.
* Could you add a test for the case where two coders register the same name?
* The following code
{code}
" cannot be registered because its coder name " + coderFactory
{code}
shouldn't it be coderFactory.getCoderName()?
> Seeking a better approach allowing to customize and configure erasure coders
> ----------------------------------------------------------------------------
>
> Key: HADOOP-13200
> URL: https://issues.apache.org/jira/browse/HADOOP-13200
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Tim Yao
> Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments: HADOOP-13200.02.patch, HADOOP-13200.03.patch,
> HADOOP-13200.04.patch, HADOOP-13200.05.patch, HADOOP-13200.06.patch
>
>
> This is a follow-on task for HADOOP-13010 as discussed over there. There may
> be some better approach allowing to customize and configure erasure coders
> than the current having raw coder factory, as [~cmccabe] suggested. Will copy
> the relevant comments here to continue the discussion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
