[
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000516#comment-16000516
]
Tsuyoshi Ozawa commented on HADOOP-14284:
-----------------------------------------
[~andrew.wang] Once HADOOP-14386 is merged, I think we can finish this jira
soon. The test failures we're facing with the latest patch is caused by
updating Guava in timelineserver test module to the newer version than 0.14,
which is the version removing LimitInputStream. After HADOOP-14386, the problem
will be solved at the implementation level.
More important point is that whether we will reach consensus or not.
[~djp] [~vinodkv] could you share your opinion based on the information we
shared after your comments? The looks large patch, however, it only changes the
code of import statement and pom.xml. diff size is as follows as a reference:
{quote}
$ git diff --shortstat d6eed5acca222a281401c1d524824f0460ea7826
1241 files changed, 2946 insertions(+), 2137 deletions(-) 1241 files changed,
2946 insertions(+), 2137 deletions(-)
{quote}
I think maintaining all of staffs of Guava in Hadoop side is also tough work,
so shading Guava looks to me like a good solution. The Guava problem is an
ecosystem-wide problem as you know. If we can solve here, it's good for Hadoop
ecosystem.
> Shade Guava everywhere
> ----------------------
>
> Key: HADOOP-14284
> URL: https://issues.apache.org/jira/browse/HADOOP-14284
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0-alpha3
> Reporter: Andrew Wang
> Assignee: Tsuyoshi Ozawa
> Priority: Blocker
> Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch,
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch,
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts.
> Unfortunately, these projects also consume our private artifacts like
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams.
> This isn't a requirement for all dependency upgrades, but it's necessary for
> known-bad dependencies like Guava.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
