[ https://issues.apache.org/jira/browse/HADOOP-14180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007395#comment-16007395 ]
Akira Ajisaka commented on HADOOP-14180: ---------------------------------------- Thanks [~xiaobingo] and [~liuml07]. The patch mostly looks good to me. Two comments: 1. Would you add {{@Test}} to {{testDeleteSubdir}}, {{testGetFileStatusFileAndDirectory}}, and {{testMkdirsForExistingFile}} in TestAliyunFileSystemContract.java? 2. Would you replace {{AssertionFailedError}} with {{AssertionError}} in TestSwiftFileSystemContract.java? org.junit.Assert does not throw junit.framework.AssertionFailedError. > FileSystem contract tests to replace JUnit 3 with 4 > --------------------------------------------------- > > Key: HADOOP-14180 > URL: https://issues.apache.org/jira/browse/HADOOP-14180 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Mingliang Liu > Assignee: Xiaobing Zhou > Labels: test > Attachments: HADOOP-14180.000.patch, HADOOP-14180.001.patch > > > This is from discussion in [HADOOP-14170], as Steve commented: > {quote} > ...it's time to move this to JUnit 4, annotate all tests with @test, and make > the test cases skip if they don't have the test FS defined. JUnit 3 doesn't > support Assume, so when I do test runs without the s3n or s3 fs specced, I > get lots of errors I just ignore. > ...Move to Junit 4, and, in our own code, find everywhere we've subclassed a > method to make the test a no-op, and insert an Assume.assumeTrue(false) in > there so they skip properly. > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org