[ 
https://issues.apache.org/jira/browse/HADOOP-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017831#comment-16017831
 ] 

Mingliang Liu commented on HADOOP-14432:
----------------------------------------

+1

Committing.

> S3A copyFromLocalFile to be robust, tested
> ------------------------------------------
>
>                 Key: HADOOP-14432
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14432
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-14432-001.patch
>
>
> {{S3AFileSystem.copyFromLocalFile()}}
> Doesn't
> * check for local file existing. Fix: check and raise FNFE (today: 
> AmazonClientException is raised)
> * check for dest being a directory. Fix: Better checks before upload
> * have any tests. Fix: write the tests
> this is related to the committer work, but doesn't depend on it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to