[ https://issues.apache.org/jira/browse/HADOOP-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020013#comment-16020013 ]
Xiaoyu Yao commented on HADOOP-14166: ------------------------------------- Thanks [~surendrasingh] for reporting the issue and post the fix. The patch looks good to me. +1 > Reset the DecayRpcScheduler AvgResponseTime metric to zero when queue is not > used > --------------------------------------------------------------------------------- > > Key: HADOOP-14166 > URL: https://issues.apache.org/jira/browse/HADOOP-14166 > Project: Hadoop Common > Issue Type: Bug > Components: common > Reporter: Surendra Singh Lilhore > Assignee: Surendra Singh Lilhore > Attachments: HADOOP-14166.001.patch > > > {noformat} > "name" : "Hadoop:service=NameNode,name=DecayRpcSchedulerMetrics2.ipc.8020", > "modelerType" : "DecayRpcSchedulerMetrics2.ipc.8020", > "tag.Context" : "ipc.8020", > "tag.Hostname" : "host1", > "DecayedCallVolume" : 3, > "UniqueCallers" : 1, > "Caller(root).Volume" : 266, > "Caller(root).Priority" : 3, > "Priority.0.AvgResponseTime" : 6.151201023385511E-5, > "Priority.1.AvgResponseTime" : 0.0, > "Priority.2.AvgResponseTime" : 0.0, > "Priority.3.AvgResponseTime" : 1.184686336544601, > "Priority.0.CompletedCallVolume" : 0, > "Priority.1.CompletedCallVolume" : 0, > "Priority.2.CompletedCallVolume" : 0, > "Priority.3.CompletedCallVolume" : 2, > "CallVolume" : 266 > {noformat} > "Priority.0.AvgResponseTime" is always "6.151201023385511E-5" even the queue > is not used for long time. > {code} > if (lastAvg > PRECISION || averageResponseTime > PRECISION) { > if (enableDecay) { > final double decayed = decayFactor * lastAvg + averageResponseTime; > LOG.info("Decayed " + i + " time " + decayed); > responseTimeAvgInLastWindow.set(i, decayed); > } else { > responseTimeAvgInLastWindow.set(i, averageResponseTime); > } > } > {code} > we should reset it to zero when above condition is false. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org