[ https://issues.apache.org/jira/browse/HADOOP-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041376#comment-16041376 ]
Aaron Fabbri edited comment on HADOOP-14476 at 6/7/17 6:28 PM: --------------------------------------------------------------- Attaching v2 patch. Changes from v1: - Add section in testing.md doc on limitations of the inconsistency injection. - Add new test ITestS3AInconsistency, similar to what we discussed above. Some test cleanup for ITestS3GuardListConsistency - Add a class comment making its purpose clearer. - Move unrelated test case into its own class. was (Author: fabbri): Attaching v2 patch. Changes from v1: - Add section in testing.md doc on limitations of the inconsistency injection. - Add new test ITestS3AInconsistency, similar to what we discussed above. - Some test cleanup for ITestS3GuardListConsistency - Add a class comment making its purpose clearer. - Move unrelated test case into its own class. > make InconsistentAmazonS3Client usable in downstream tests > ---------------------------------------------------------- > > Key: HADOOP-14476 > URL: https://issues.apache.org/jira/browse/HADOOP-14476 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3, test > Affects Versions: HADOOP-13345 > Reporter: Steve Loughran > Assignee: Aaron Fabbri > Attachments: HADOOP-14476-HADOOP-13345.001.patch, > HADOOP-14476-HADOOP-13345.002.patch > > > It's important for downstream apps to be able to verify that s3guard works by > making the AWS client inconsistent (so demonstrate problems), then turn > s3guard on to verify that they go away. > This can be done by exposing the {{InconsistentAmazonS3Client}} > # move the factory to the production source > # make delay configurable for when you want a really long delay > # have factory code log @ warn when a non-default factory is used. > # mention in s3a testing.md > I think we could look at the name of the option, > {{fs.s3a.s3.client.factory.impl}} too. I'd like something which has > "internal" in it, and without the duplication of s3a.s3 -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org