[ 
https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Mackrory updated HADOOP-14499:
-----------------------------------
    Attachment: HADOOP-14499-HADOOP-13345.002.patch

Attaching a patch that:
* Resolves the findbugs issue that started this
* Does not attempt to do any clean up of directories in Local
* Updates the javadoc on prune() in MetadataStore to be files only, not 
directories (I don't think the interface as currently written makes it possible 
to safely prune directories without hitting the same concerns as here).
* Keeps the same test from the .001. patch, unmodified

Re-tested with -Ds3guard -Dauth. ITestS3AContractRename and 
ITestS3AInconsistency failed during the parallel test run because their fork-# 
directories were missing, etc. Passed when re-run in isolation, but those 
failures are new. Must be unrelated to this, though.

> Findbugs warning in LocalMetadataStore
> --------------------------------------
>
>                 Key: HADOOP-14499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14499
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14499-HADOOP-13345.001.patch, 
> HADOOP-14499-HADOOP-13345.002.patch
>
>
> First saw this raised by Yetus on HADOOP-14433:
> {code}
> Bug type UC_USELESS_OBJECT (click for details)
> In class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore
> In method org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore.prune(long)
> Value ancestors
> Type java.util.LinkedList
> At LocalMetadataStore.java:[line 300]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to