[
https://issues.apache.org/jira/browse/HADOOP-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055234#comment-16055234
]
Akira Ajisaka commented on HADOOP-14542:
----------------------------------------
{code}
if (logger != null && logger.isDebugEnabled()) {
logger.debug("Exception in closing " + c, e);
}
{code}
Would you use {}-placeholders and remove {{logger.isDebugEnabled()}}? I'm +1 if
that is addressed.
> Add IOUtils.cleanup or something that accepts slf4j logger API
> --------------------------------------------------------------
>
> Key: HADOOP-14542
> URL: https://issues.apache.org/jira/browse/HADOOP-14542
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Akira Ajisaka
> Assignee: Chen Liang
> Attachments: HADOOP-14542.001.patch
>
>
> Split from HADOOP-14539.
> Now IOUtils.cleanup only accepts commons-logging logger API. Now we are
> migrating the APIs to slf4j, slf4j logger API should be accepted as well.
> Adding {{IOUtils.cleanup(Logger, Closeable...)}} causes
> {{IOUtils.cleanup(null, Closeable...)}} to fail (incompatible change), so
> it's better to change the method name to avoid the conflict.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
