[ https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055963#comment-16055963 ]
Xiao Chen commented on HADOOP-14521: ------------------------------------ bq. pre-commit I tried to ran {{TestAclsEndToEnd}} before and after applying this patch on branch-2.8. It was passing before, failing after. Could you try the same? Perhaps something odd happening on my local. (I didn't look inside except for running the tests) bq. I don't fully understand your comment. Your patch is cool, just the tool was confused due to the naming. {{smart-apply-patch}} uses the wiki's naming convention to choose patch for trunk, branch-2, branch-2.8 etc. I was saying running {{dev-support/bin/smart-apply-patch HADOOP-14521}} was trying to apply the branch-2.8 patch when running on trunk: {quote} $ ./dev-support/bin/smart-apply-patch HADOOP-14521 Processing: HADOOP-14521 HADOOP-14521 patch is being downloaded at Tue Jun 20 08:31:28 PDT 2017 from https://issues.apache.org/jira/secure/attachment/12873350/HDFS-11804-branch-2.8.patch -> Downloaded ERROR: Aborting! HADOOP-14521 cannot be verified. {quote} Maybe we can improve yetus on that since as you said, pre-commit ran fine. > KMS client needs retry logic > ---------------------------- > > Key: HADOOP-14521 > URL: https://issues.apache.org/jira/browse/HADOOP-14521 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 2.6.0 > Reporter: Rushabh S Shah > Assignee: Rushabh S Shah > Attachments: HADOOP-14521.09.patch, HDFS-11804-branch-2.8.patch, > HDFS-11804-trunk-1.patch, HDFS-11804-trunk-2.patch, HDFS-11804-trunk-3.patch, > HDFS-11804-trunk-4.patch, HDFS-11804-trunk-5.patch, HDFS-11804-trunk-6.patch, > HDFS-11804-trunk-7.patch, HDFS-11804-trunk-8.patch, HDFS-11804-trunk.patch > > > The kms client appears to have no retry logic – at all. It's completely > decoupled from the ipc retry logic. This has major impacts if the KMS is > unreachable for any reason, including but not limited to network connection > issues, timeouts, the +restart during an upgrade+. > This has some major ramifications: > # Jobs may fail to submit, although oozie resubmit logic should mask it > # Non-oozie launchers may experience higher rates if they do not already have > retry logic. > # Tasks reading EZ files will fail, probably be masked by framework reattempts > # EZ file creation fails after creating a 0-length file – client receives > EDEK in the create response, then fails when decrypting the EDEK > # Bulk hadoop fs copies, and maybe distcp, will prematurely fail -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org